Add optional auth config to docker push#1133
Merged
aanand merged 2 commits intodocker:masterfrom Jul 22, 2016
Merged
Conversation
Author
|
@aanand can you look into this? |
Contributor
|
Thanks for this. Looks sound, but needs tests. |
Author
|
I had added tests.Can you look into this again |
Contributor
|
Great! LGTM |
Contributor
|
LGTM, might need a rebase |
added 2 commits
July 22, 2016 10:04
Signed-off-by: Keerthan Reddy Mala <kmala@deis.com>
Signed-off-by: Keerthan Reddy Mala <kmala@deis.com>
Author
|
@dnephin rebased |
Author
|
in which release can i expect this to be in? |
Contributor
|
This will be in 1.10 |
Author
|
Thanks!! Any tentative date for the release? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.